From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YchQz-0002Am-0i for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:41:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YchQv-0003u3-JT for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:41:24 -0400 Message-ID: <5519C2FD.4020605@suse.de> Date: Mon, 30 Mar 2015 23:41:17 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-3-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1425615506-1829-3-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, mst@redhat.com, andreas.faerber@web.de, lcapitulino@redhat.com Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 06.03.2015 um 05:18 schrieb David Gibson: > The hmp commands "irq" and "pic" are a bit of a mess. They're implemen= ted > on a number of targets, but not all. On sparc32 and LM32 they do targe= t > specific things, but on the remainder (i386, ppc and mips) they call in= to > the i8259 PIC code. >=20 > But really, what these commands do shouldn't be dependent on the target > arch, but on the specific machine that's in use. On ppc, for example, > the "prep" machine usually does have an ISA bridge with an i8259, but > most of the other machine types have never had an i8259 at all. Simila= rly > the sparc specific target would stop working if we ever had a sparc32 > machine that wasn't sun4m. >=20 > This patch cleans things up by implementing these hmp commands on all > targets via a MachineClass callback. If the callback is NULL, for now > we fallback to target specific defaults that match the existing behavio= ur. > The hope is we can remove those later with target specific cleanups. >=20 > Signed-off-by: David Gibson > --- > hw/intc/i8259.c | 4 ++-- > include/hw/boards.h | 2 ++ > include/hw/i386/pc.h | 4 ++-- > monitor.c | 57 ++++++++++++++++++++++++++++++++++++++------= -------- > 4 files changed, 48 insertions(+), 19 deletions(-) This commit message is terribly misleading: Nothing is done wrt CONFIG_I8259 AFAICT. What about "monitor: Implement info irq and info pit for all targets"? The implementation looks fine and once fixed can get a Reviewed-by: Andreas F=E4rber Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)