From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YciQx-0001qQ-77 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 18:45:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YciQu-0000kf-0u for qemu-devel@nongnu.org; Mon, 30 Mar 2015 18:45:27 -0400 Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:44439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YciQt-0000kU-Qz for qemu-devel@nongnu.org; Mon, 30 Mar 2015 18:45:23 -0400 Message-ID: <5519D201.5040304@redhat.com> Date: Mon, 30 Mar 2015 16:45:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-7-git-send-email-eblake@redhat.com> <87a8yz51uc.fsf@blackfin.pond.sub.org> <55140EFD.805@redhat.com> <87k2y3yclk.fsf@blackfin.pond.sub.org> In-Reply-To: <87k2y3yclk.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gAMHd2U8jeChtVF3JlERj688FP0h9kqGr" Subject: Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gAMHd2U8jeChtVF3JlERj688FP0h9kqGr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 09:58 AM, Markus Armbruster wrote: >>> /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at= EOF. >> >> Huh. I thought I had git set up to reject me from making commits like >> that locally, but obviously not. >=20 > There's another one in PATCH 13: >=20 > /home/armbru/work/qemu/.git/rebase-apply/patch:156: new blank line at E= OF. >=20 >> http://wiki.qemu.org/Contribute/SubmitAPatch should probably mention t= he >> magic one-time setup to use to turn this type of checking on... >=20 > Feel free to add it :) The wiki already mentions how: * [http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.h= tml Automate a checkpatch run on commit] but I had failed to 'chmod +x .git/hooks/pre-commit' to actually use it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gAMHd2U8jeChtVF3JlERj688FP0h9kqGr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGdIBAAoJEKeha0olJ0NqFqkH/jjA121e1wX4Fb2KfTLsuQKp qc5i8VkzbnUm/WZWmC2F6nygRXJHTtPh8iNTd8djZlPLbuCLHyPc5Gn3aCHjfN2Y JOQ+KuguPKrVK/D8vSaieR2bx0MP55DS1fYv7y6/STvvHdA3u2UTjJHYIfmgmLcm cQ3SMR+jKJf+VmfjDSX+4e+VeJY8a8gTEWDARTlitiGsGMgtvy/v8hOwaOh6PCgH dXjHkCPUw7XCzOvwCj1v7ir/hL629h441/dmNEQMLZh9o3gbw+l3CzQPRvkhLeOU 31uDQRUsKHZTNiNcpG+P+TMXjS2ljMEQfe12gzYD5zOxRhPE4G/O6j0frjD033A= =whij -----END PGP SIGNATURE----- --gAMHd2U8jeChtVF3JlERj688FP0h9kqGr--