From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcyCi-0001Wg-JN for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:35:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcyCd-0002Mx-KB for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:35:48 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:49001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcyCc-0002Mj-Rb for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:35:43 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 31 Mar 2015 09:35:42 -0600 Message-ID: <551ABEC8.6030300@linux.vnet.ibm.com> Date: Tue, 31 Mar 2015 11:35:36 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1427808437-535644-1-git-send-email-stefanb@linux.vnet.ibm.com> <551AAA82.9090608@redhat.com> <551AABE5.1020509@redhat.com> In-Reply-To: <551AABE5.1020509@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tpm_tis: fix format for 64bit variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-trivial@nongnu.org Cc: qemu-devel@nongnu.org On 03/31/2015 10:15 AM, Eric Blake wrote: > On 03/31/2015 08:09 AM, Eric Blake wrote: >> On 03/31/2015 07:27 AM, Stefan Berger wrote: >>> Signed-off-by: Stefan Berger >>> --- >>> hw/tpm/tpm_tis.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c >>> index 815c8ea..52e0148 100644 >>> --- a/hw/tpm/tpm_tis.c >>> +++ b/hw/tpm/tpm_tis.c >>> @@ -814,7 +814,7 @@ static void tpm_tis_mmio_write_intern(void *opaque, hwaddr addr, >>> tis->loc[locty].state == TPM_TIS_STATE_COMPLETION) { >>> /* drop the byte */ >>> } else { >>> - DPRINTF("tpm_tis: Data to send to TPM: %08x (size=%d)\n", >>> + DPRINTF("tpm_tis: Data to send to TPM: %08lx (size=%d)\n", >> NACK. When printing uint64_t val, you HAVE to use PRIx64, not lx, for >> the sake of 32-bit platforms. > Furthermore, you could have caught this much sooner if you fix the > definition of DPRINTF. This file used: > > #ifdef DEBUG_TIS > #define DPRINTF(fmt, ...) \ > do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0) > #else > #define DPRINTF(fmt, ...) \ > do { } while (0) > #endif > > which is bad, because the compiler CAN'T see the type mismatch unless > you turn debugging on (alas, we have a LOT of files in the code base > with similar bad patterns). A better example is hw/display/cg3.c: > > /* Change to 1 to enable debugging */ > #define DEBUG_CG3 0 > ... > #define DPRINTF(fmt, ...) do { \ > if (DEBUG_CG3) { \ > printf("CG3: " fmt , ## __VA_ARGS__); \ > } \ > } while (0); I'll move it towards that after 2.3 is out. Stefan