From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd3FX-0001Wx-6Q
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 16:59:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd3FS-0003pE-9p
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 16:59:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd3FS-0003p4-17
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 16:58:58 -0400
Message-ID: <551B0A89.8060507@redhat.com>
Date: Tue, 31 Mar 2015 16:58:49 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1427129798-21590-1-git-send-email-jsnow@redhat.com>
	<1427129798-21590-5-git-send-email-jsnow@redhat.com>
	<CAPyFy2BuV2EzpqbjiGr8jfeFbKcLPtUj0=S_0Zen3Qx_+d0a9w@mail.gmail.com>
In-Reply-To: <CAPyFy2BuV2EzpqbjiGr8jfeFbKcLPtUj0=S_0Zen3Qx_+d0a9w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>



On 03/31/2015 04:55 PM, Ed Maste wrote:
> On 23 March 2015 at 12:56, John Snow <jsnow@redhat.com> wrote:
>> My pattern was cyclical every 256 bytes, so it missed a fairly obvious
>> failure case. Add some rand() pepper into the test pattern, and for la=
rge
>> patterns that exceed 256 sectors, start writing an ID per-sector so th=
at
>> we never generate identical sector patterns.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Tested-by: Andreas F=C3=A4rber <afaerber@suse.de>
>> Message-id: 1426811056-2202-5-git-send-email-jsnow@redhat.com
>> ---
>>   tests/ahci-test.c | 36 ++++++++++++++++++++++++++++--------
>>   1 file changed, 28 insertions(+), 8 deletions(-)
>
> As of the introduction of this test the test suite fails on FreeBSD,
> with 6 errors of the form:
>
> ERROR:tests/ahci-test.c:790:ahci_test_io_rw_simple: assertion failed
> (memcmp(tx, rx, bufsize) =3D=3D 0): (0xffffffffffffffff =3D=3D 0x000000=
00)
> GTester: last random seed: R02S76f68c4cfb2d54af66de227ed44fd54a
>
> I haven't yet done any investigation beyond bisecting.
>

which test case does it fail under? io_rw_simple is shared by a number=20
of different tests.

I suspect deeply that this test pattern has just unearthed an existing=20
problem.