From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40029)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd4Dh-00053S-Cs
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 18:01:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd4Dd-00016L-DW
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 18:01:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42521)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Yd4Dd-000165-4R
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 18:01:09 -0400
Message-ID: <551B1922.1060806@redhat.com>
Date: Tue, 31 Mar 2015 18:01:06 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1427129798-21590-1-git-send-email-jsnow@redhat.com>
	<1427129798-21590-5-git-send-email-jsnow@redhat.com>
	<CAPyFy2BuV2EzpqbjiGr8jfeFbKcLPtUj0=S_0Zen3Qx_+d0a9w@mail.gmail.com>
	<551B0A89.8060507@redhat.com>
	<CAPyFy2C8be-WtuzkAh_uNybNNAK5HbWg-GhbmueRE0L8wequWw@mail.gmail.com>
	<551B153D.1080405@redhat.com>
	<CAPyFy2DmTei78-ctdv5V3-oTHcODdZ3YZwZRTooAJUtre+tg+g@mail.gmail.com>
In-Reply-To: <CAPyFy2DmTei78-ctdv5V3-oTHcODdZ3YZwZRTooAJUtre+tg+g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 03/31/2015 05:55 PM, Ed Maste wrote:
> On 31 March 2015 at 17:44, John Snow <jsnow@redhat.com> wrote:
>>
>> My apologies;
>
> Not at all, thanks for your help!
>
>> Head into your build directory and try this:
>>
>>> make tests/ahci-test
>>> export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
>>> export QTEST_QEMU_IMG=./qemu-img
>>> ./tests/ahci-test
>>
>> This should show you which test in particular is failing. I have a hunch it
>> will be the PIO, again...
>
> Correct:
>
> feynman% ./tests/ahci-test
> /i386/ahci/sanity: OK
> /i386/ahci/pci_spec: OK
> /i386/ahci/pci_enable: OK
> /i386/ahci/hba_spec: OK
> /i386/ahci/hba_enable: OK
> /i386/ahci/identify: OK
> /i386/ahci/io/pio/lba28/simple: **
> ERROR:tests/ahci-test.c:790:ahci_test_io_rw_simple: assertion failed
> (memcmp(tx, rx, bufsize) == 0): (0xffffffffffffffff == 0x00000000)
> zsh: abort (core dumped)  ./tests/ahci-test
>
>> In the meantime, what is your setup? which release, what architecture?
>
> This is the FreeBSD stable/10 branch on amd64 (so part way between
> 10.1 and what will become 10.2):
>
> FreeBSD feynman 10.1-STABLE FreeBSD 10.1-STABLE #28
> r280427+86df2de(stable-10): Thu Mar 26 16:07:47 EDT 2015
> emaste@feynman:/tank/emaste/obj/tank/emaste/src/git-stable-10/sys/GENERIC
>   amd64
>

Thanks, one more if you have the spare cycles; and then I'll go prepare 
a machine to debug for myself.

./ahci-test -p /i386/ahci/io/pio/lba28/short
./ahci-test -p /i386/ahci/io/pio/lba48/short

quite likely both work for you, while changing short for "simple" "long" 
or "double" probably all fail.

./ahci-test -p /i386/ahci/io/dma/

probably launches a series of tests that also all work correctly.

Thank you for your help,
--John