Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

On 03/30/2015 04:45 PM, Eric Blake wrote:
> On 03/26/2015 09:58 AM, Markus Armbruster wrote:
> 
>>>> /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at EOF.
>>>
>>> Huh. I thought I had git set up to reject me from making commits like
>>> that locally, but obviously not.
>>
>> There's another one in PATCH 13:
>>
>> /home/armbru/work/qemu/.git/rebase-apply/patch:156: new blank line at EOF.
>>
>>> http://wiki.qemu.org/Contribute/SubmitAPatch should probably mention the
>>> magic one-time setup to use to turn this type of checking on...
>>
>> Feel free to add it :)
> 
> The wiki already mentions how:
> *
> [http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
> Automate a checkpatch run on commit]
> 
> but I had failed to 'chmod +x .git/hooks/pre-commit' to actually use it.

Actually, scripts/checkpatch.pl does NOT flag blank lines; so I want to
also wire up git's default .git/hooks/pre-commit checker which can flag
that type of damage (Stefan's blog and/or checkpatch.pl may need an update).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]