From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Justin Ossevoort <justin@quarantainenet.nl>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim
Date: Wed, 01 Apr 2015 09:54:23 +0200 [thread overview]
Message-ID: <551BA42F.8060104@redhat.com> (raw)
In-Reply-To: <551AD35F.2020509@redhat.com>
On 31/03/2015 19:03, Eric Blake wrote:
>>>
>>> Apart from this, looks good.
> Changing a "return":{} to "return":0 is not backwards-compatible.
Why not?
Paolo
>> I'm CCing the qemu-ga maintainer.
> I failed to do that in my beefier reply, so I'm responding here
> just to say that this needs a v2.
next prev parent reply other threads:[~2015-04-01 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 15:14 [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim Justin Ossevoort
2015-03-31 16:52 ` Paolo Bonzini
2015-03-31 17:03 ` Eric Blake
2015-04-01 7:54 ` Paolo Bonzini [this message]
2015-04-01 12:33 ` Eric Blake
2015-04-01 16:49 ` Paolo Bonzini
2015-04-02 7:37 ` Justin Ossevoort
2015-03-31 17:01 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BA42F.8060104@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=justin@quarantainenet.nl \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).