From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YdDTv-0005Cq-7S
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 03:54:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YdDTq-0004QT-5M
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 03:54:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YdDTp-0004Or-W1
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 03:54:30 -0400
Message-ID: <551BA42F.8060104@redhat.com>
Date: Wed, 01 Apr 2015 09:54:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1427814871-1936-1-git-send-email-justin@quarantainenet.nl>
	<551AD0C9.6080507@redhat.com> <551AD35F.2020509@redhat.com>
In-Reply-To: <551AD35F.2020509@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Justin Ossevoort <justin@quarantainenet.nl>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>



On 31/03/2015 19:03, Eric Blake wrote:
>>> 
>>> Apart from this, looks good.
> Changing a "return":{} to "return":0 is not backwards-compatible.

Why not?

Paolo

>> I'm CCing the qemu-ga maintainer.
> I failed to do that in my beefier reply, so I'm responding here
> just to say that this needs a v2.