From: Marcel Apfelbaum <marcel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: "Tony Krowiak" <akrowiak@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary
Date: Wed, 01 Apr 2015 12:27:34 +0300 [thread overview]
Message-ID: <551BBA06.3020208@redhat.com> (raw)
In-Reply-To: <551BB8FA.9020803@redhat.com>
On 04/01/2015 12:23 PM, Paolo Bonzini wrote:
>
>
> On 01/04/2015 11:14, Marcel Apfelbaum wrote:
>> This + 'monkey-patch' may be a feasible solution for 2.4
>
> Why monkey-patch and not just revert?
There are already several machine sub-types that have
their own options, some of the code I think
it was added after the 'dynamic options' patch, so revert will
not be enough.
We will need to go over the new options and add them to the global
list.
At this point, adding the machine options to the global list during
machine init seems to be a less risky and
will also keep options per machine.
Maybe I'll try it and see how it looks.
Thanks,
Marcel
>
> Paolo
>
next prev parent reply other threads:[~2015-04-01 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 14:21 [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary Tony Krowiak
2015-04-01 6:54 ` Marcel Apfelbaum
2015-04-01 8:01 ` Paolo Bonzini
2015-04-01 8:06 ` Marcel Apfelbaum
2015-04-01 8:20 ` Paolo Bonzini
2015-04-01 8:42 ` Markus Armbruster
2015-04-01 9:07 ` Paolo Bonzini
2015-04-01 9:14 ` Marcel Apfelbaum
2015-04-01 9:23 ` Paolo Bonzini
2015-04-01 9:27 ` Marcel Apfelbaum [this message]
2015-04-01 8:28 ` Markus Armbruster
2015-04-01 14:51 ` Marcel Apfelbaum
2015-04-01 15:53 ` Markus Armbruster
2015-04-01 16:11 ` Marcel Apfelbaum
2015-04-01 16:20 ` Eric Blake
2015-04-01 16:31 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BBA06.3020208@redhat.com \
--to=marcel@redhat.com \
--cc=afaerber@suse.de \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).