From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdI7k-0007P7-B7 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 08:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdI7h-0002Gi-Ex for qemu-devel@nongnu.org; Wed, 01 Apr 2015 08:52:00 -0400 Received: from smtp.citrix.com ([66.165.176.89]:29789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdI7h-0002FV-AC for qemu-devel@nongnu.org; Wed, 01 Apr 2015 08:51:57 -0400 Message-ID: <551BE9D0.1090003@citrix.com> Date: Wed, 1 Apr 2015 13:51:28 +0100 From: Julien Grall MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , yunhong.jiang@intel.com Cc: Ian Campbell , Ian Jackson , "qemu-devel@nongnu.org" , xen-devel Hi, I'm looking to replace any call to xc_domain_bind_pt_irq and xc_domain_unbind_pt_irq by specific IRQ type helpers. I found one strange call which will always fail in xen_pt_msix_update_remap. The function xc_domain_unbind_pt_irq is called with PT_IRQ_TYPE_MSI which is not supported by the function. I'm not familiar with x86 passthrough but this looks wrong to me. Am I right? Shouldn't we replace this call by xc_domain_unbind_msi_irq? Regards, -- Julien Grall