From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdLpN-0000jL-1c for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdLpJ-0003hh-Q7 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:49:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdLpJ-0003hS-IJ for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:49:13 -0400 Message-ID: <551C2184.3020402@redhat.com> Date: Wed, 01 Apr 2015 19:49:08 +0300 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1427897284-31473-1-git-send-email-marcel@redhat.com> <551C0C02.3050003@redhat.com> <551C1D3C.30908@redhat.com> In-Reply-To: <551C1D3C.30908@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, akrowiak@linux.vnet.ibm.com, armbru@redhat.com On 04/01/2015 07:30 PM, Eric Blake wrote: > On 04/01/2015 09:17 AM, Eric Blake wrote: >> On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote: >>> Commit 49d2e64 (machine: remove qemu_machine_opts global list) made >>> machine machine options specific to machine sub-type, leaving >> >> At the risk of sounding like a machine: s/machine machine/machine/ >> >>> the qemu_machine_opts desc array empty. Sadly this is the place >>> qmp_query_command_line_options is looking for supported options. >>> >>> As a fix for for 2.3 the machine_qemu_opts are restored only >>> for the scope of qemu-config, bringing together all machines >> >> s/machines/machines'/ >> >>> properties. We need to find a better fix for 2.4. Hi Eric, Thank you for your help. > > As discussed on the other thread, we may want a v2: Submitted. > > >> I also tested that query-command-line-options on qemu.git + this patch >> provided a superset of the options exposed by >> 2:qemu-system-x86-2.1.3-3.fc21.x86_64 as installed on Fedora 21, while >> without this patch it had no options. > > The problem is that the superset includes per-machine options, even for > machines where they don't apply. I think it's better for 2.3 to be > conservative (advertise no less than before, so we don't regress) than > to lie (advertising something we don't support is risky). I agree, this is the reason we wanted per-machine options, to not lie to higher levels. Thanks, Marcel >