qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	yunhong.jiang@intel.com, Ian Jackson <ian.jackson@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c
Date: Wed, 1 Apr 2015 18:25:37 +0100	[thread overview]
Message-ID: <551C2A11.20909@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1504011629490.7690@kaball.uk.xensource.com>

Hi,

On 01/04/2015 16:32, Stefano Stabellini wrote:
> On Wed, 1 Apr 2015, Julien Grall wrote:
>> Hi,
>>
>> I'm looking to replace any call to xc_domain_bind_pt_irq and
>> xc_domain_unbind_pt_irq by specific IRQ type helpers.
>>
>> I found one strange call which will always fail in xen_pt_msix_update_remap.
>> The function xc_domain_unbind_pt_irq is called with PT_IRQ_TYPE_MSI
>> which is not supported by the function.
>>
>> I'm not familiar with x86 passthrough but this looks wrong to me. Am I
>> right? Shouldn't we replace this call by xc_domain_unbind_msi_irq?
>
> I think that nobody noticed because xen_pt_msix_update_remap is only
> called by xen_pt_region_add at assignement time, when pirq is
> XEN_PT_UNASSIGNED_PIRQ, therefore xc_domain_unbind_pt_irq is not
> actually called.

Right. I think it would be possible to hit the problem if the guest 
decide to relocate the BAR.

> Yes, I think it should be xc_domain_unbind_msi_irq.

I don't have any x86 platform. Can someone take this item?

Otherwise I will do a blind port.

Regards,

-- 
Julien Grall

      reply	other threads:[~2015-04-01 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 12:51 [Qemu-devel] Question about unbind MSI in xen_pt_msi.c Julien Grall
2015-04-01 15:32 ` Stefano Stabellini
2015-04-01 17:25   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551C2A11.20909@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).