From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1YdMOh-0006ki-By
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1YdMOd-0001sO-6p
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:25:47 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:32147)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1YdMOd-0001re-0k
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:25:43 -0400
Message-ID: <551C2A11.20909@citrix.com>
Date: Wed, 1 Apr 2015 18:25:37 +0100
From: Julien Grall <julien.grall@citrix.com>
MIME-Version: 1.0
References: <551BE9D0.1090003@citrix.com>
	<alpine.DEB.2.02.1504011629490.7690@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1504011629490.7690@kaball.uk.xensource.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, yunhong.jiang@intel.com, Ian Jackson <ian.jackson@eu.citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, xen-devel <xen-devel@lists.xen.org>

Hi,

On 01/04/2015 16:32, Stefano Stabellini wrote:
> On Wed, 1 Apr 2015, Julien Grall wrote:
>> Hi,
>>
>> I'm looking to replace any call to xc_domain_bind_pt_irq and
>> xc_domain_unbind_pt_irq by specific IRQ type helpers.
>>
>> I found one strange call which will always fail in xen_pt_msix_update_remap.
>> The function xc_domain_unbind_pt_irq is called with PT_IRQ_TYPE_MSI
>> which is not supported by the function.
>>
>> I'm not familiar with x86 passthrough but this looks wrong to me. Am I
>> right? Shouldn't we replace this call by xc_domain_unbind_msi_irq?
>
> I think that nobody noticed because xen_pt_msix_update_remap is only
> called by xen_pt_region_add at assignement time, when pirq is
> XEN_PT_UNASSIGNED_PIRQ, therefore xc_domain_unbind_pt_irq is not
> actually called.

Right. I think it would be possible to hit the problem if the guest 
decide to relocate the BAR.

> Yes, I think it should be xc_domain_unbind_msi_irq.

I don't have any x86 platform. Can someone take this item?

Otherwise I will do a blind port.

Regards,

-- 
Julien Grall