From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdMSw-0001ZD-0s for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:30:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdMSr-0004Ve-V7 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:30:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdMSr-0004Rk-O8 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 13:30:05 -0400 Message-ID: <551C2B0D.7040403@redhat.com> Date: Wed, 01 Apr 2015 11:29:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427906841-1576-1-git-send-email-marcel@redhat.com> In-Reply-To: <1427906841-1576-1-git-send-email-marcel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OPHbhwN8ujlqBx5XB2dKw24ArL45C798w" Subject: Re: [Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, akrowiak@linux.vnet.ibm.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OPHbhwN8ujlqBx5XB2dKw24ArL45C798w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/01/2015 10:47 AM, Marcel Apfelbaum wrote: > Commit 49d2e64 (machine: remove qemu_machine_opts global list) > made machine options specific to machine sub-type, leaving > the qemu_machine_opts desc array empty. Sadly this is the place > qmp_query_command_line_options is looking for supported options. >=20 > As a fix for for 2.3 the machine_qemu_opts (the generic ones) > are restored only for qemu-config scope. > We need to find a better fix for 2.4. >=20 > Reported-by: Tony Krowiak > Signed-off-by: Marcel Apfelbaum > --- > + },{ > + .name =3D "firmware", > + .type =3D QEMU_OPT_STRING, > + .help =3D "firmware image", > + },{ > + .name =3D "iommu", > + .type =3D QEMU_OPT_BOOL, > + .help =3D "Set on/off to enable/disable Intel IOMMU (VT-d)= ", > + },{ > + .name =3D "suppress-vmdesc", > + .type =3D QEMU_OPT_BOOL, > + .help =3D "Set on to disable self-describing migration", > + }, No longer a strict superset of the Fedora 21 qemu-kvm, which had: "parameters": [ { "name": "max-ram-below-4g", "help": "maximum ram below the 4G boundary (32bit boundary)" , "type": "size" }, { "name": "kvm-type", "help": "Specifies the KVM virtualization mode (HV, PR)", "type": "string" }, { "name": "firmware", "help": "firmware image", "type": "string" }, (remembering that query-command-line-options does things in reverse order). I don't think iommu and suppress-vmdesc hurt to add, but we shouldn't lose kvm-type or max-ram-below-4g, if those were advertised at the point prior to the QemuOpts conversion. (I didn't actually research, though, whether I'm comparing against downstream Fedora qemu-kvm patches instead of upstream...) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OPHbhwN8ujlqBx5XB2dKw24ArL45C798w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVHCsNAAoJEKeha0olJ0NqvpQH/ju+ytlveJ6E0a+Se3AD1OA+ SnJOSCFag8760mfrEMgv3aI3g6Xzj5YcHXEQwnQVKXi8qN6XgjM8zgOVDpDzF69e nu6wtF5V8q3K3ztjpCoW1l6mtCtAeQ/yJpnQXtZaQNoFBqFQPAg5QVeuNBRbDmq0 F+zhHGyea9xOxKbqkvAffAsgZh8MtKld1EL+uT/I7DrhogKj1RVK91GQFUpMFGpH FKf+QaV//mAvBYJyxjUxjaqOZq5alBXbdWVAQT70uGHGx5Z0KhtxS9sOSFxFND86 6QaEPyav6tfV+NekiOKJ89lL0oJXjCwmNt82MuyljprOPiTmCsDjMbZZi2Y1bD8= =hyXi -----END PGP SIGNATURE----- --OPHbhwN8ujlqBx5XB2dKw24ArL45C798w--