From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdPy5-0002Lu-26 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 17:14:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdPy4-0005LN-8N for qemu-devel@nongnu.org; Wed, 01 Apr 2015 17:14:33 -0400 Sender: Paolo Bonzini Message-ID: <551C5FAF.7010303@redhat.com> Date: Wed, 01 Apr 2015 23:14:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427911244-22565-1-git-send-email-emaste@freebsd.org> <551C5DE7.70904@redhat.com> In-Reply-To: <551C5DE7.70904@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Ed Maste , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 01/04/2015 23:06, John Snow wrote: > > if (qemu == NULL) { > fprintf(stderr, "..."); > g_assert_not_reached(); > } > > Though that does read a little strangely. ("Here's a nice error message > for something we are asserting will never happen.") Just "exit(1);" then. :) Good idea, this is annoying. Paolo