Re: [Qemu-devel] [PATCH for-2.3] hw/arm/vexpress: Don't double-free flash filename

[Stefan Weil <sw@weilnetz.de>]

Am 02.04.2015 um 11:52 schrieb Peter Maydell:
> Commits 6e05a12f8f7f and db25a1581 both attempt to fix the
> same "failed to free memory containing flash filename" bug,
> with the effect that when they were both applied we ended
> up freeing the memory twice. Delete the spurious extra free.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Shannon's patch fixes the virt.c board; I checked the other
> boards touched by 6e05a12f8f7f and they don't have the problem
> (either due to no conflicting patch or because the g_free()
> calls were in the same place and the merge combined them.)
>
>  hw/arm/vexpress.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
> index dd04527..54dd967 100644
> --- a/hw/arm/vexpress.c
> +++ b/hw/arm/vexpress.c
> @@ -583,7 +583,6 @@ static void vexpress_common_init(MachineState *machine)
>              error_report("Could not load ROM image '%s'", bios_name);
>              exit(1);
>          }
> -        g_free(fn);
>      }
>  
>      /* Motherboard peripherals: the wiring is the same but the

Signed-off-by: Stefan Weil <sw@weilnetz.de>