From: Stefan Weil <sw@weilnetz.de>
To: Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
arei.gonglei@huawei.com
Cc: hangaohuai@huawei.com, shannon.zhaol@linaro.org,
peter.huangpeng@huawei.com, christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free
Date: Thu, 02 Apr 2015 12:51:37 +0200 [thread overview]
Message-ID: <551D1F39.4010802@weilnetz.de> (raw)
In-Reply-To: <1427944026-8968-1-git-send-email-zhaoshenglong@huawei.com>
Am 02.04.2015 um 05:07 schrieb Shannon Zhao:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/arm/virt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
> error_report("Could not load ROM image '%s'", bios_name);
> exit(1);
> }
> - g_free(fn);
> }
>
> create_one_flash("virt.flash0", flashbase, flashsize);
Signed-off-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2015-04-02 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 3:07 [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free Shannon Zhao
2015-04-02 9:29 ` Peter Maydell
2015-04-02 10:51 ` Stefan Weil [this message]
2015-04-02 11:14 ` Gonglei
2015-04-02 11:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551D1F39.4010802@weilnetz.de \
--to=sw@weilnetz.de \
--cc=arei.gonglei@huawei.com \
--cc=christoffer.dall@linaro.org \
--cc=hangaohuai@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaol@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).