From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Ydcin-0001HO-6a
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 06:51:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Ydcik-0000M6-09
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 06:51:37 -0400
Received: from mail-r83.rz.uni-mannheim.de ([134.155.96.83]:35002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Ydcij-0000M0-Qb
	for qemu-devel@nongnu.org; Thu, 02 Apr 2015 06:51:33 -0400
Message-ID: <551D1F39.4010802@weilnetz.de>
Date: Thu, 02 Apr 2015 12:51:37 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1427944026-8968-1-git-send-email-zhaoshenglong@huawei.com>
In-Reply-To: <1427944026-8968-1-git-send-email-zhaoshenglong@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double
 free
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>, qemu-devel@nongnu.org, peter.maydell@linaro.org, arei.gonglei@huawei.com
Cc: hangaohuai@huawei.com, shannon.zhaol@linaro.org, peter.huangpeng@huawei.com, christoffer.dall@linaro.org

Am 02.04.2015 um 05:07 schrieb Shannon Zhao:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
>  hw/arm/virt.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
>              error_report("Could not load ROM image '%s'", bios_name);
>              exit(1);
>          }
> -        g_free(fn);
>      }
>  
>      create_one_flash("virt.flash0", flashbase, flashsize);

Signed-off-by: Stefan Weil <sw@weilnetz.de>