* Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free
2015-04-02 3:07 [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free Shannon Zhao
@ 2015-04-02 9:29 ` Peter Maydell
2015-04-02 10:51 ` Stefan Weil
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2015-04-02 9:29 UTC (permalink / raw)
To: Shannon Zhao
Cc: hangaohuai, Stefan Weil, QEMU Developers, Huangpeng (Peter),
Gonglei (Arei), shannon.zhaol, Christoffer Dall
On 2 April 2015 at 04:07, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/arm/virt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
> error_report("Could not load ROM image '%s'", bios_name);
> exit(1);
> }
> - g_free(fn);
> }
>
> create_one_flash("virt.flash0", flashbase, flashsize);
Oops, yes. vexpress.c has the same double-free too.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free
2015-04-02 3:07 [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free Shannon Zhao
2015-04-02 9:29 ` Peter Maydell
@ 2015-04-02 10:51 ` Stefan Weil
2015-04-02 11:14 ` Gonglei
2015-04-02 11:50 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Weil @ 2015-04-02 10:51 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel, peter.maydell, arei.gonglei
Cc: hangaohuai, shannon.zhaol, peter.huangpeng, christoffer.dall
Am 02.04.2015 um 05:07 schrieb Shannon Zhao:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/arm/virt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
> error_report("Could not load ROM image '%s'", bios_name);
> exit(1);
> }
> - g_free(fn);
> }
>
> create_one_flash("virt.flash0", flashbase, flashsize);
Signed-off-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free
2015-04-02 3:07 [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free Shannon Zhao
2015-04-02 9:29 ` Peter Maydell
2015-04-02 10:51 ` Stefan Weil
@ 2015-04-02 11:14 ` Gonglei
2015-04-02 11:50 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Gonglei @ 2015-04-02 11:14 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel, peter.maydell, sw
Cc: hangaohuai, shannon.zhaol, peter.huangpeng, christoffer.dall
On 2015/4/2 11:07, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/arm/virt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
> error_report("Could not load ROM image '%s'", bios_name);
> exit(1);
> }
> - g_free(fn);
> }
>
> create_one_flash("virt.flash0", flashbase, flashsize);
>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free
2015-04-02 3:07 [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free Shannon Zhao
` (2 preceding siblings ...)
2015-04-02 11:14 ` Gonglei
@ 2015-04-02 11:50 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2015-04-02 11:50 UTC (permalink / raw)
To: Shannon Zhao
Cc: hangaohuai, Stefan Weil, QEMU Developers, Huangpeng (Peter),
Gonglei (Arei), shannon.zhaol, Christoffer Dall
On 2 April 2015 at 04:07, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/arm/virt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread