Re: [Qemu-devel] [PATCH RFC 02/19] qapi: Fix C identifiers generated for names containing '.'

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

On 04/02/2015 11:28 AM, Markus Armbruster wrote:
> c_fun() maps '.' to '_', c_var() doesn't.  Nothing prevents '.' in
> QAPI names that get passed to c_var().
> 
> Which QAPI names get passed to c_fun(), to c_var(), or to both is not
> obvious.  Names of command parameters and struct type members get
> passed to c_var().
> 
> c_var() strips a leading '*', but this cannot happen.  c_fun()
> doesn't.
> 
> Fix c_var() to work exactly like c_fun().
> 
> Perhaps they should be replaced by a single mapping function.

How much harder is that to do?

Also, this commit probably means my qapi testsuite enhancements ought to
add tests that we support downstream extensions (__name.name_blah) in a
variety of situations. But I'm merely adding it to my (growing) list of
post-series additions, and won't hold up v6 adding it.

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  scripts/qapi.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

If it's not too hard to use a single mapping function, that might look
prettier.  But from the raw perspective of fixing an inconsistency in
the code:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]