From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye2Qy-0007qU-U8 for qemu-devel@nongnu.org; Fri, 03 Apr 2015 10:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye2Qu-00055v-UG for qemu-devel@nongnu.org; Fri, 03 Apr 2015 10:18:56 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:37898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye2Qu-00055p-Nz for qemu-devel@nongnu.org; Fri, 03 Apr 2015 10:18:52 -0400 Received: by wibgn9 with SMTP id gn9so141421209wib.1 for ; Fri, 03 Apr 2015 07:18:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <551EA149.2070401@redhat.com> Date: Fri, 03 Apr 2015 16:18:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1426919142-20770-1-git-send-email-cota@braap.org> <20150403000810.GA21077@flamenco> In-Reply-To: <20150403000810.GA21077@flamenco> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org On 03/04/2015 02:08, Emilio G. Cota wrote: > On Sat, Mar 21, 2015 at 02:25:42 -0400, Emilio G. Cota wrote: >> Note that this test >> if (b & ((1 << len) - 1)) >> can be simplified to >> if (b & 1) >> , since we know that iff the first bit of a tb is set, >> all other bits from that tb are set too. >> >> Signed-off-by: Emilio G. Cota >> --- >> translate-all.c | 39 +++++---------------------------------- >> 1 file changed, 5 insertions(+), 34 deletions(-) > > *ping* > http://patchwork.ozlabs.org/patch/452907/ > > Any takers? get_maintainer.pl doesn't suggest anybody to send this to. > > This gets rid of an unnecessary (and hairy) function: bitmap_set(). > I even took the time to double-check with a test program that > this function is indeed equivalent to bitmap_set(). Nobody was looking because of the hard freeze, I guess. The patch looks good. Paolo