From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Aleksandar Rikalo <arikalo@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Waldemar Brodkorb <wbx@uclibc-ng.org>
Subject: Re: [PATCH-for-9.1 v2 1/2] target/mips: Pass page table entry size in bytes to get_pte()
Date: Tue, 13 Aug 2024 21:00:13 +1000 [thread overview]
Message-ID: <551ca808-a865-4f80-b35c-c6c02f4bb672@linaro.org> (raw)
In-Reply-To: <20240813101856.49469-2-philmd@linaro.org>
On 8/13/24 20:18, Philippe Mathieu-Daudé wrote:
> - if (ptei > entry_size) {
> + if (ptei > entry_bytes >> 3) {
Shifting the wrong way here.
r~
next prev parent reply other threads:[~2024-08-13 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 10:18 [PATCH-for-9.1 v2 0/2] target/mips: Use correct MMU index in get_pte() Philippe Mathieu-Daudé
2024-08-13 10:18 ` [PATCH-for-9.1 v2 1/2] target/mips: Pass page table entry size in bytes to get_pte() Philippe Mathieu-Daudé
2024-08-13 11:00 ` Richard Henderson [this message]
2024-08-13 11:02 ` Richard Henderson
2024-08-13 12:16 ` Philippe Mathieu-Daudé
2024-08-13 10:18 ` [PATCH-for-9.1 v2 2/2] target/mips: Use correct MMU index in get_pte() Philippe Mathieu-Daudé
2024-08-13 11:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551ca808-a865-4f80-b35c-c6c02f4bb672@linaro.org \
--to=richard.henderson@linaro.org \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@uclibc-ng.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).