From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727F5C433E0 for ; Tue, 26 Jan 2021 21:40:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E60BB2053B for ; Tue, 26 Jan 2021 21:40:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E60BB2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4W4Z-0002Qp-Q9 for qemu-devel@archiver.kernel.org; Tue, 26 Jan 2021 16:40:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4W3Q-0001R8-Mp for qemu-devel@nongnu.org; Tue, 26 Jan 2021 16:39:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4W3O-0004bX-Hc for qemu-devel@nongnu.org; Tue, 26 Jan 2021 16:39:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611697153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sxqv5yUwQFbVFgh+iPBiF0//0KbZRTwceB6ZVlVRKSA=; b=R/Br1W/NHss6vSI1jUAQSPstJ0TSt3mW+XhESchGBA5Ro7EuTBZPGiwMmGNU7lTrPiXjhU ZxN/7+gX4PAoM2w5YAAsZlenymAPUGTgGNNFh5xx+JKGQ4E5bcYxEMnHLd4x3r87uq8C4a fuQGaZ0X2rzNmHPJDVofmmsffJbAV2k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-sMtPW2MROReVkyT0Erv8lQ-1; Tue, 26 Jan 2021 16:39:08 -0500 X-MC-Unique: sMtPW2MROReVkyT0Erv8lQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E55CB8017FB; Tue, 26 Jan 2021 21:39:05 +0000 (UTC) Received: from [10.10.112.247] (ovpn-112-247.rdu2.redhat.com [10.10.112.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id E300863746; Tue, 26 Jan 2021 21:38:57 +0000 (UTC) Subject: Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux To: Thomas Huth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Jiaxun Yang References: <20210118063808.12471-1-jiaxun.yang@flygoat.com> <20210118063808.12471-9-jiaxun.yang@flygoat.com> <20210118103345.GE1789637@redhat.com> <929c3ec1-9419-908a-6b5e-ce3ae78f6011@redhat.com> From: John Snow Message-ID: <551e153e-34da-28bd-c67f-d2a688ad987b@redhat.com> Date: Tue, 26 Jan 2021 16:38:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <929c3ec1-9419-908a-6b5e-ce3ae78f6011@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Viktor Prutyanov , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Alistair Francis , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Greg Kurz , Kevin Wolf , qemu-ppc@nongnu.org, kvm@vger.kernel.org, Paolo Bonzini , Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/19/21 8:41 AM, Thomas Huth wrote: > On 18/01/2021 11.33, Daniel P. Berrangé wrote: >> On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote: >>> Alpine Linux[1] is a security-oriented, lightweight Linux distribution >>> based on musl libc and busybox. >>> >>> It it popular among Docker guests and embedded applications. >>> >>> Adding it to test against different libc. >>> >>> [1]: https://alpinelinux.org/ >>> >>> Signed-off-by: Jiaxun Yang >>> --- >>>   tests/docker/dockerfiles/alpine.docker | 57 ++++++++++++++++++++++++++ >>>   1 file changed, 57 insertions(+) >>>   create mode 100644 tests/docker/dockerfiles/alpine.docker >>> >>> diff --git a/tests/docker/dockerfiles/alpine.docker >>> b/tests/docker/dockerfiles/alpine.docker >>> new file mode 100644 >>> index 0000000000..5be5198d00 >>> --- /dev/null >>> +++ b/tests/docker/dockerfiles/alpine.docker >>> @@ -0,0 +1,57 @@ >>> + >>> +FROM alpine:edge >>> + >>> +RUN apk update >>> +RUN apk upgrade >>> + >>> +# Please keep this list sorted alphabetically >>> +ENV PACKAGES \ >>> +    alsa-lib-dev \ >>> +    bash \ >>> +    bison \ >> >> This shouldn't be required. > > bison and flex were required to avoid some warnings in the past while > compiling the dtc submodule ... but I thought we got rid of the problem > at one point in time, so this can be removed now, indeed. > >>> +    build-base \ >> >> This seems to be a meta packae that pulls in other >> misc toolchain packages. Please list the pieces we >> need explicitly instead. > > Looking at the "Depends" list on > https://pkgs.alpinelinux.org/package/v3.3/main/x86/build-base there are > only 6 dependencies and we need most of those for QEMU anyway, so I > think it is ok to keep build-base here. > >>> +    coreutils \ >>> +    curl-dev \ >>> +    flex \ >> >> This shouldn't be needed. >> >>> +    git \ >>> +    glib-dev \ >>> +    glib-static \ >>> +    gnutls-dev \ >>> +    gtk+3.0-dev \ >>> +    libaio-dev \ >>> +    libcap-dev \ >> >> Should not be required, as we use cap-ng. > > Right. > >>> +    libcap-ng-dev \ >>> +    libjpeg-turbo-dev \ >>> +    libnfs-dev \ >>> +    libpng-dev \ >>> +    libseccomp-dev \ >>> +    libssh-dev \ >>> +    libusb-dev \ >>> +    libxml2-dev \ >>> +    linux-headers \ >> >> Is this really needed ? We don't install kernel-headers on other >> distros AFAICT. > > I tried a build without this package, and it works fine indeed. > >>> +    lzo-dev \ >>> +    mesa-dev \ >>> +    mesa-egl \ >>> +    mesa-gbm \ >>> +    meson \ >>> +    ncurses-dev \ >>> +    ninja \ >>> +    paxmark \ >> >> What is this needed for ? > > Seems like it also can be dropped. > >>> +    perl \ >>> +    pulseaudio-dev \ >>> +    python3 \ >>> +    py3-sphinx \ >>> +    shadow \ >> >> Is this really needed ? > > See: > https://www.spinics.net/lists/kvm/msg231556.html > > I can remove the superfluous packages when picking up the patch, no need > to respin just because of this. > >  Thomas > > You can refer to my post earlier this January for a "minimal" Alpine Linux build, if you wish. My goal was to find the smallest set of packages possible without passing any explicit configure flags. I wonder if it's worth having layered "core build" and "test build" images so that we can smoke test the minimalistic build from time to time -- I seem to recall Dan posting information about a dependency management tool for Dockerfiles, but I admit I didn't look too closely at what problem that solves, exactly. --js