From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfR9I-0000l7-EM for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfR9E-00026n-OI for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:54:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfR9E-00026e-Gi for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:54:24 -0400 Message-ID: <5523B755.2080909@redhat.com> Date: Tue, 07 Apr 2015 12:54:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427932716-11800-1-git-send-email-namit@cs.technion.ac.il> <551D3768.9090404@redhat.com> <5523AE38.6000701@suse.de> <5523B2C6.5080601@redhat.com> <5523B518.5050902@suse.de> In-Reply-To: <5523B518.5050902@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: rth@twiddle.net, mst@redhat.com, nadav.amit@gmail.com, Eduardo Habkost , Nadav Amit On 07/04/2015 12:44, Andreas F=E4rber wrote: >> > It can change at runtime, though, if you're using the KVM in-kernel = LAPIC. > Got a pointer? A quick git-grep doesn't show anything in hw/ or > kvm-all.c or target-i386/ assigning cpu_index, so it'll always have the > initial value. Not cpu_index, s->apicbase's MSR_IA32_APICBASE_BSP bit can change with KVM in-kernel LAPIC. It cannot change with QEMU's userspace LAPIC. Because it can change, you have to call apic_designate_bsp for all CPUs and not only on CPU 0. Paolo