From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfV6y-0002jh-VU for qemu-devel@nongnu.org; Tue, 07 Apr 2015 11:08:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfV6s-0004xM-Uo for qemu-devel@nongnu.org; Tue, 07 Apr 2015 11:08:20 -0400 Message-ID: <5523F2D7.50704@redhat.com> Date: Tue, 07 Apr 2015 09:08:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428411796-2852-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1428411796-2852-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TE5QD7VsTN48JC3WmEtT61MpAAP95p3o6" Subject: Re: [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TE5QD7VsTN48JC3WmEtT61MpAAP95p3o6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/07/2015 07:03 AM, Kevin Wolf wrote: > In recent qemu versions, it is possible to override the backing file > name and format that is stored in the image file with values given at > runtime. In such cases, the temporary override could end up in the > image header if the qcow2 header was updated, while obviously correct > behaviour would be to leave the on-disk backing file path/format > unchanged. >=20 > Fix this and add a test case for it. >=20 > Reported-by: Michael Tokarev > Signed-off-by: Kevin Wolf > --- > v2: > - Now freeing instead of leaking the new strings in qcow2_close() >=20 > block/qcow2.c | 29 ++++++++++---- > block/qcow2.h | 6 +++ > tests/qemu-iotests/130 | 95 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/130.out | 43 +++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 5 files changed, 167 insertions(+), 7 deletions(-) > create mode 100755 tests/qemu-iotests/130 > create mode 100644 tests/qemu-iotests/130.out Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TE5QD7VsTN48JC3WmEtT61MpAAP95p3o6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVI/LXAAoJEKeha0olJ0Nq/Z4H/RLUOI7aZ1/uRoAq/P3+PGg4 ZUWSyThkWqsSej3uX1PcJFJupZi1Hwjrg838wPIU3S537HZt84ZRMcAuIfuWfvu5 fjPyo3fBCrCrHc6MKLbmFJBWjMFZtcmK9WBgtYL5MJp0+9x/VH4PiNCwm6ELntMx 1eAh8NA17Yo6j/AqFliEXci8r8L3YOEypkzNsZZLTf3/EYESgnHazUW7s7G4tyCc dY6vmMaI6GvmEP8fdJH1U7zIKoSCaMBWNnmzCRnV7+aOcCTfWqE8DFyC6ijM6QwY yUWNvOIdYxgsCQKnWiKc2JA4xzdSEKZTmh2JIX0WHeYJD2w32Fy2QNOg/biHQt4= =m6t+ -----END PGP SIGNATURE----- --TE5QD7VsTN48JC3WmEtT61MpAAP95p3o6--