From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YflOg-0001Rj-Ti for qemu-devel@nongnu.org; Wed, 08 Apr 2015 04:31:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YflOb-0005w1-2N for qemu-devel@nongnu.org; Wed, 08 Apr 2015 04:31:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YflOa-0005vu-UQ for qemu-devel@nongnu.org; Wed, 08 Apr 2015 04:31:37 -0400 Message-ID: <5524E763.7020108@redhat.com> Date: Wed, 08 Apr 2015 10:31:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428439603-8549-1-git-send-email-ehabkost@redhat.com> <1428439603-8549-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1428439603-8549-6-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] target-i386: X86CPU::xlevel2 QOM property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Igor Mammedov , Jiri Denemark , =?windows-1252?Q?Andreas_F=E4rber?= On 07/04/2015 22:46, Eduardo Habkost wrote: > We already have "level" and "xlevel", only "xlevel2" is missing. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 6ccea14..ae07af4 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -2080,7 +2080,7 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefinition *def, Error **errp) > object_property_set_int(OBJECT(cpu), def->model, "model", errp); > object_property_set_int(OBJECT(cpu), def->stepping, "stepping", errp); > object_property_set_int(OBJECT(cpu), def->xlevel, "xlevel", errp); > - env->cpuid_xlevel2 = def->xlevel2; > + object_property_set_int(OBJECT(cpu), def->xlevel2, "xlevel2", errp); > cpu->cache_info_passthrough = def->cache_info_passthrough; > object_property_set_str(OBJECT(cpu), def->model_id, "model-id", errp); > for (w = 0; w < FEATURE_WORDS; w++) { > @@ -3063,6 +3063,7 @@ static Property x86_cpu_properties[] = { > DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true), > DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0), > DEFINE_PROP_UINT32("xlevel", X86CPU, env.cpuid_xlevel, 0), > + DEFINE_PROP_UINT32("xlevel2", X86CPU, env.cpuid_xlevel2, 0), > DEFINE_PROP_END_OF_LIST() > }; > > Reviewed-by: Paolo Bonzini