From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Yfnlh-0003C2-JT
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:03:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YfnlZ-000832-QV
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:03:37 -0400
Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:34264)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YfnlZ-00081s-Jg
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:03:29 -0400
Received: by widjs5 with SMTP id js5so30375105wid.1
	for <qemu-devel@nongnu.org>; Wed, 08 Apr 2015 04:03:28 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <55250AFD.3060203@redhat.com>
Date: Wed, 08 Apr 2015 13:03:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428437400-8474-1-git-send-email-peter.maydell@linaro.org>
	<1428437400-8474-8-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1428437400-8474-8-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new
	address_space_ld*/st* functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?windows-1252?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>



On 07/04/2015 22:09, Peter Maydell wrote:
> +#ifdef NEED_CPU_H
> +uint32_t address_space_lduw(AddressSpace *as, hwaddr addr,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +uint32_t address_space_ldl(AddressSpace *as, hwaddr addr,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +uint64_t address_space_ldq(AddressSpace *as, hwaddr addr,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +void address_space_stl_notdirty(AddressSpace *as, hwaddr addr, uint32_t val,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +void address_space_stw(AddressSpace *as, hwaddr addr, uint32_t val,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +void address_space_stl(AddressSpace *as, hwaddr addr, uint32_t val,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +void address_space_stq(AddressSpace *as, hwaddr addr, uint64_t val,
> +                            MemTxAttrs attrs, MemTxResult *result);
> +#endif

I think we do not want to expose these at all (or at least, all users
should really be CPUs and hence use *_phys functions).

S390 is always big-endian, and watch_mem_read/write can use the same
buffer trick as subpages (and in fact should probably use memattrs as well).

So, please at least add a comment that these functions are deprecated,
and check if watch_mem_read/write should be handled like subpages.

Thanks,

Paolo