From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yfnmk-0004Ag-QN for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:04:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yfnmg-00023a-I1 for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:04:42 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:36752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yfnmg-00022D-BA for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:04:38 -0400 Received: by wizk4 with SMTP id k4so50425818wiz.1 for ; Wed, 08 Apr 2015 04:04:37 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55250B42.1070307@redhat.com> Date: Wed, 08 Apr 2015 13:04:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428437400-8474-1-git-send-email-peter.maydell@linaro.org> <1428437400-8474-10-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1428437400-8474-10-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/14] exec.c: Capture the memory attributes for a watchpoint hit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Peter Crosthwaite , patches@linaro.org, Greg Bellows , "Edgar E. Iglesias" , =?windows-1252?Q?Alex_Benn=E9e?= , Richard Henderson On 07/04/2015 22:09, Peter Maydell wrote: > Capture the memory attributes for the transaction which triggered > a watchpoint; this allows CPU specific code to implement features > like ARM's "user-mode only WPs also hit for LDRT/STRT accesses > made from privileged code". > > Signed-off-by: Peter Maydell Oops, here we are. :) If you want to move the patch early, and possibly convert watch_mem_read/write to use a buffer in the style of subpages, that would be great. Paolo