From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfpU0-0005EH-4A for qemu-devel@nongnu.org; Wed, 08 Apr 2015 08:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfpTw-0000U3-Sg for qemu-devel@nongnu.org; Wed, 08 Apr 2015 08:53:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47868 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfpTw-0000Tr-My for qemu-devel@nongnu.org; Wed, 08 Apr 2015 08:53:24 -0400 Message-ID: <552524C2.6070208@suse.de> Date: Wed, 08 Apr 2015 14:53:22 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428439603-8549-1-git-send-email-ehabkost@redhat.com> <1428439603-8549-4-git-send-email-ehabkost@redhat.com> <5524E73C.3020708@redhat.com> <20150408110600.GR7031@thinpad.lan.raisama.net> In-Reply-To: <20150408110600.GR7031@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Jiri Denemark , qemu-devel@nongnu.org, Igor Mammedov Am 08.04.2015 um 13:06 schrieb Eduardo Habkost: > On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote: >> On 07/04/2015 22:46, Eduardo Habkost wrote: >>> This uses the feature name arrays to register "feat-*" QOM properties >>> for feature flags. This simply adds the properties so they can be >>> configured using -global, but doesn't change x86_cpu_parse_featurestr= () >>> to use them yet. >> >> Out of curiosity, why the prefix? (Also, perhaps a prefix such as >> "cpuid-*" would be better since the property often only affects the >> cpuid leaves, rather than the availability of the feature itself). >=20 > The prefix exists to allow those properties to be easily identified by > software that doesn't know the full list of feature names (I even took > advantage of that on the x86-cpu-model-dump script). >=20 > About the reason for using the "feat-" prefix, the short answer is "it'= s > the prefix used in the last patch that implemented this (by Igor)". I > think the first suggestion was to use "f-", then we changed to > "feature-" or "feat-", and simply stayed using "feat-" in the last few > versions. Fair to mention that they did not all get equal review. ;) > But I like the "cpuid-" suggestion and plan to use it on v2. Any > objections? Assuming it's technically correct, +1 for cpuid-. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)