From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfxPm-00033E-OS for qemu-devel@nongnu.org; Wed, 08 Apr 2015 17:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfxPi-0005LR-OT for qemu-devel@nongnu.org; Wed, 08 Apr 2015 17:21:38 -0400 Message-ID: <55259BDC.8040208@suse.de> Date: Wed, 08 Apr 2015 23:21:32 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428523029-13620-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1428523029-13620-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tcg/tcg-op.c: Fix ld/st of 64 bit values on 32-bit bigendian hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Alexander Graf , qemu-ppc@nongnu.org, Igor Mammedov , Paolo Bonzini , Richard Henderson Am 08.04.2015 um 21:57 schrieb Peter Maydell: > Commit 951c6300f7 out-of-lined the 32-bit-host versions of > tcg_gen_{ld,st}_i64, but in the process it inadvertently changed > an #ifdef HOST_WORDS_BIGENDIAN to #ifdef TCG_TARGET_WORDS_BIGENDIAN. > Since the latter doesn't get defined anywhere this meant we always > took the "LE host" codepath, and stored the two halves of the value > in the wrong order on BE hosts. This typically breaks any 64-bit > guest on a 32-bit BE host completely, and will have possibly more > subtle effects even for 32-bit guests. >=20 > Switch the ifdef back to HOST_WORDS_BIGENDIAN. Doh, not the first time we've screwed up such an ifdef... >=20 > Signed-off-by: Peter Maydell > --- > I checked that with this fix we no longer fail catastrophically > on the first insn of the x86-64 BIOS image, but since I don't have > a convenient way to display the graphical screen from the PPC > box I have access to I didn't check that it continued to do > sensible things thereafter. Andreas, could you confirm this fixes > the breakage you're seeing? It fixes the observed make check breakage on ppc. i586 still works, too. Tested-by: Andreas F=E4rber I'll check VNC tomorrow. I'm assuming this is for-2.3 material. Thanks a lot, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)