From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yg1Es-0006HW-4I for qemu-devel@nongnu.org; Wed, 08 Apr 2015 21:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yg1Eo-0007Qb-TU for qemu-devel@nongnu.org; Wed, 08 Apr 2015 21:26:38 -0400 Received: from mga02.intel.com ([134.134.136.20]:35775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yg1Eo-0007QT-O0 for qemu-devel@nongnu.org; Wed, 08 Apr 2015 21:26:34 -0400 Message-ID: <5525D4B2.9060104@linux.intel.com> Date: Thu, 09 Apr 2015 09:24:02 +0800 From: Xiao Guangrong MIME-Version: 1.0 References: <5524CC0E.8020208@linux.intel.com> <55250714.1050400@redhat.com> In-Reply-To: <55250714.1050400@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Li, Wanpeng" , Marcelo Tosatti , "qemu-devel@nongnu.org" , kvm@vger.kernel.org On 04/08/2015 06:46 PM, Paolo Bonzini wrote: > > > On 08/04/2015 08:34, Xiao Guangrong wrote: >> We noticed that KVM keeps tracking dirty for the memslots when >> live migration failed which causes bad performance due to huge >> page mapping disallowed for this kind of memslot >> >> It is caused by slot flags does not properly sync-ed between Qemu >> and KVM. Current code doing slot update depends on slot->flags >> which hopes to omit unnecessary ioctl. However, slot->flags only >> reflects the stauts of corresponding memory region, vmsave and >> live migration do dirty tracking which overset >> KVM_MEM_LOG_DIRTY_PAGES for the slot. That causes the slot status >> recorded in the flags does not exactly match the stauts in kernel. >> >> We fixed it by introducing slot->is_dirty_logging which indicates >> the dirty status in kernel so that it helps us to sync the status >> between userspace and kernel >> >> Wanpeng Li >> Signed-off-by: Xiao Guangrong > > Hi Xiao, > > the patch looks good. > > However, I am planning to remove s->migration_log completely from QEMU > 2.4 and have slot->flags also track the migration state. This has the > side effect of fixing this bug. I'll Cc you on the patches when I post > them (next week probably). Good to know it, look forward to your patches. Thank you, Paolo!