From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yg9ai-0004KT-0f
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 06:21:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yg9ae-0002Bs-JY
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 06:21:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51950)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yg9ae-0002Be-C4
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 06:21:40 -0400
Message-ID: <552652AA.5070701@redhat.com>
Date: Thu, 09 Apr 2015 12:21:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428437400-8474-1-git-send-email-peter.maydell@linaro.org>
	<1428437400-8474-7-git-send-email-peter.maydell@linaro.org>
	<20150409095904.GH30629@toto>
	<CAFEAcA_mVTnVAuekCFm=s4cfhoVi2cH2D1niJzEMNY=dbYjLzg@mail.gmail.com>
In-Reply-To: <CAFEAcA_mVTnVAuekCFm=s4cfhoVi2cH2D1niJzEMNY=dbYjLzg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take
 transaction attributes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, =?UTF-8?B?QWxleCBCZW5u?= =?UTF-8?B?w6ll?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>



On 09/04/2015 12:14, Peter Maydell wrote:
> On 9 April 2015 at 10:59, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
>> > On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote:
>>> >> Make address_space_rw take transaction attributes, rather
>>> >> than always using the 'unspecified' attributes.
>> >
>> > Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>> >
>> > I guess that we eventually will need to convert the dma_
>> > functions?
> Probably, though I'm not clear what they bring to the party
> that the basic address_space_* functions don't (part of why
> I left them alone).

At this point, some memory barriers, basically.

Initially the IOMMU implementation was done in the dma_* functions
(using something called IIRC a DMAContext), but now they just take an
AddressSpace.

Paolo