From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgBmi-0005qT-SQ for qemu-devel@nongnu.org; Thu, 09 Apr 2015 08:42:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgBmd-00043r-DG for qemu-devel@nongnu.org; Thu, 09 Apr 2015 08:42:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgBmd-00043l-7v for qemu-devel@nongnu.org; Thu, 09 Apr 2015 08:42:11 -0400 Message-ID: <55267399.5020703@redhat.com> Date: Thu, 09 Apr 2015 14:42:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428437400-8474-1-git-send-email-peter.maydell@linaro.org> <1428437400-8474-8-git-send-email-peter.maydell@linaro.org> <55250AFD.3060203@redhat.com> <552669DF.40705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , Patch Tracking , QEMU Developers , Greg Bellows , "Edgar E. Iglesias" , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Richard Henderson On 09/04/2015 14:38, Peter Maydell wrote: > They need to be in memory.h because cpu-all.h doesn't have > all the typedefs. Also, memory.h seems to me clearly the > best place, since it's where we declare the MemoryRegion > and AddressSpace related functions. > > It's certainly true that using target-cpu-endian functions > in a device is somewhat suspicious, but that's generally > true of all those functions, not just these new > address_space_* ones. > > So I think I'm happy to add a comment that the functions > are deprecated for use outside target-*/, but I think they > are still necessary. Fair enough, that will do. Paolo