From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgFlW-0000dF-Pe for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgFlS-0007F9-LY for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:57:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49175 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgFlS-0007En-F9 for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:57:14 -0400 Message-ID: <5526AF66.3000801@suse.de> Date: Thu, 09 Apr 2015 18:57:10 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1428587538-8765-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1428587538-8765-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Chrysostomos Nanakos , Paolo Bonzini Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi: > libxseg has changed license to GPLv3. QEMU includes GPL "v2 only" code > which is not compatible with GPLv3. This means the resulting binaries > may not be redistributable! >=20 > Disable Archipelago (libxseg) by default to prevent accidental license > violations. Also warn if linking against libxseg is enabled to remind > the user. >=20 > Note that this commit does not constitute any advice about software > licensing. If you have doubts you should consult a lawyer. :) >=20 > Cc: Chrysostomos Nanakos > Suggested-by: Kevin Wolf > Reported-by: Andreas F=C3=A4rber > Signed-off-by: Stefan Hajnoczi > --- > configure | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > While libxseg reconsiders its license, let's disable it by default and = warn > users that they need to carefully check whether the licenses are compat= ible. >=20 > diff --git a/configure b/configure > index 09c9225..9219ba3 100755 > --- a/configure > +++ b/configure > @@ -327,7 +327,7 @@ seccomp=3D"" > glusterfs=3D"" > glusterfs_discard=3D"no" > glusterfs_zerofill=3D"no" > -archipelago=3D"" > +archipelago=3D"no" > gtk=3D"" > gtkabi=3D"" > vte=3D"" > @@ -3173,6 +3173,12 @@ EOF > archipelago=3D"yes" > libs_tools=3D"$archipelago_libs $libs_tools" > libs_softmmu=3D"$archipelago_libs $libs_softmmu" > + > + echo "WARNING: Please check the licenses of QEMU and libxseg carefull= y." > + echo "GPLv3 versions of libxseg may not be compatible with QEMU's " FWIW trailing space in argument (in case you send a pull yourself) > + echo "license and therefore prevent redistribution." > + echo > + echo "To disable Archipelago, use --disable-archipelago" Since you change the default, that's not strictly necessary any more but not wrong either. > else > if test "$archipelago" =3D "yes" ; then > feature_not_found "Archipelago backend support" "Install libxs= eg devel" Reviewed-by: Andreas F=C3=A4rber Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)