From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgIxr-0006nd-Qk for qemu-devel@nongnu.org; Thu, 09 Apr 2015 16:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgIxo-0001Ew-Il for qemu-devel@nongnu.org; Thu, 09 Apr 2015 16:22:15 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:33701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgIxo-0001Eo-CC for qemu-devel@nongnu.org; Thu, 09 Apr 2015 16:22:12 -0400 Received: by wiax7 with SMTP id x7so2400995wia.0 for ; Thu, 09 Apr 2015 13:22:11 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5526DF6F.3070908@redhat.com> Date: Thu, 09 Apr 2015 22:22:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428609450-29812-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1428609450-29812-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Peter Crosthwaite , =?windows-1252?Q?Andreas_F=E4rber?= , Stefan Hajnoczi On 09/04/2015 21:57, Eduardo Habkost wrote: > This helps us avoid memory leaks when using object_property_add_alias(), as it > is not practical for callers to save target_name to free it later. > > Eduardo Habkost (2): > qom: strdup() target property name on object_property_add_alias() > qdev: Free property names after registering gpio aliases > > hw/core/qdev.c | 2 ++ > qom/object.c | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > Good idea! Reviewed-by: Paolo Bonzini