From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias()
Date: Fri, 10 Apr 2015 00:48:30 +0200 [thread overview]
Message-ID: <552701BE.1040500@suse.de> (raw)
In-Reply-To: <5526DF6F.3070908@redhat.com>
Am 09.04.2015 um 22:22 schrieb Paolo Bonzini:
> On 09/04/2015 21:57, Eduardo Habkost wrote:
>> This helps us avoid memory leaks when using object_property_add_alias(), as it
>> is not practical for callers to save target_name to free it later.
>>
>> Eduardo Habkost (2):
>> qom: strdup() target property name on object_property_add_alias()
>> qdev: Free property names after registering gpio aliases
>>
>> hw/core/qdev.c | 2 ++
>> qom/object.c | 5 +++--
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>>
>
> Good idea!
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Looks good to me in general, I'm just surprised that there are not more
cleanups resulting out of this? At least my pc87312 series will need
changes then. Will take a deeper look another day.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-04-09 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:57 [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias() Eduardo Habkost
2015-04-09 19:57 ` [Qemu-devel] [PATCH 1/2] qom: strdup() target property name " Eduardo Habkost
2015-04-09 19:57 ` [Qemu-devel] [PATCH 2/2] qdev: Free property names after registering gpio aliases Eduardo Habkost
2015-04-09 20:22 ` [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias() Paolo Bonzini
2015-04-09 22:48 ` Andreas Färber [this message]
2015-04-28 3:16 ` Andreas Färber
2015-05-18 18:03 ` Eduardo Habkost
2015-04-10 12:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552701BE.1040500@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).