From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgLFW-00077A-VP for qemu-devel@nongnu.org; Thu, 09 Apr 2015 18:48:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgLFR-0003TQ-DA for qemu-devel@nongnu.org; Thu, 09 Apr 2015 18:48:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34385 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgLFR-0003TG-6z for qemu-devel@nongnu.org; Thu, 09 Apr 2015 18:48:33 -0400 Message-ID: <552701BE.1040500@suse.de> Date: Fri, 10 Apr 2015 00:48:30 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428609450-29812-1-git-send-email-ehabkost@redhat.com> <5526DF6F.3070908@redhat.com> In-Reply-To: <5526DF6F.3070908@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Eduardo Habkost , qemu-devel@nongnu.org Cc: Peter Crosthwaite , Stefan Hajnoczi Am 09.04.2015 um 22:22 schrieb Paolo Bonzini: > On 09/04/2015 21:57, Eduardo Habkost wrote: >> This helps us avoid memory leaks when using object_property_add_alias(= ), as it >> is not practical for callers to save target_name to free it later. >> >> Eduardo Habkost (2): >> qom: strdup() target property name on object_property_add_alias() >> qdev: Free property names after registering gpio aliases >> >> hw/core/qdev.c | 2 ++ >> qom/object.c | 5 +++-- >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >=20 > Good idea! >=20 > Reviewed-by: Paolo Bonzini Looks good to me in general, I'm just surprised that there are not more cleanups resulting out of this? At least my pc87312 series will need changes then. Will take a deeper look another day. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)