From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgRpV-0001j4-ST for qemu-devel@nongnu.org; Fri, 10 Apr 2015 01:50:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgRpO-0008NF-Nu for qemu-devel@nongnu.org; Fri, 10 Apr 2015 01:50:13 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:52239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgRpO-0008AX-5i for qemu-devel@nongnu.org; Fri, 10 Apr 2015 01:50:06 -0400 Message-ID: <55276467.7070406@huawei.com> Date: Fri, 10 Apr 2015 13:49:27 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-5-git-send-email-zhaoshenglong@huawei.com> <20150409144221.19cc2090@nial.brq.redhat.com> In-Reply-To: <20150409144221.19cc2090@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, msalter@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/4/9 20:42, Igor Mammedov wrote: > On Fri, 3 Apr 2015 18:03:36 +0800 > Shannon Zhao wrote: > >> From: Shannon Zhao >> >> Add aml_memory32_fixed() for describing device mmio region in resource template. >> These can be used to generating DSDT table for ACPI on ARM. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> --- >> hw/acpi/aml-build.c | 22 ++++++++++++++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 23 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 8d01959..fefe7c7 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -505,6 +505,28 @@ Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *arg4) >> return var; >> } >> >> +/* >> + * ACPI 1.0: 6.4.3.4 Memory32Fixed (Memory Resource Descriptor Macro) >> + */ >> +Aml *aml_memory32_fixed(uint64_t addr, uint64_t size, uint8_t rw_flag) > perhaps > s/uint64_t/uint32_t/ > > don't use uintXX for bitfields if could be helped. > Probably in this case existing AmlReadAndWrite enum should be used. > Ok, will use the enum. -- Thanks, Shannon