From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUCO-0002fC-Bc for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgUCK-0000x5-Oe for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:22:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUCK-0000wy-HB for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:21:56 -0400 Message-ID: <5527881D.6040300@redhat.com> Date: Fri, 10 Apr 2015 10:21:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428519763-21644-1-git-send-email-ehabkost@redhat.com> <1428519763-21644-4-git-send-email-ehabkost@redhat.com> <20150409184830.GB18590@thinpad.lan.raisama.net> <20150410092751.3573d267@igors-macbook-pro.local> In-Reply-To: <20150410092751.3573d267@igors-macbook-pro.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Eduardo Habkost Cc: Jiri Denemark , qemu-devel@nongnu.org, =?windows-1252?Q?Andreas_F=E4rber?= On 10/04/2015 09:27, Igor Mammedov wrote: > > + for (i = 0; names[i]; i++) { > > + char *feat_name = names[i]; > > + feat2prop(feat_name); > > + char *prop_name = g_strdup_printf("cpuid-%s", feat_name); > > BTW: I've remembered why we've chosen feat- vs. cpuid- prefix > it was to make CPU features platform neutral so that libvirt > would use the same prefix for x86, arm other targets. Ok, that make sense, but if we want to make it platform-neutral, let's spell it "feature-" or remove the prefix altogether. If we remove it, perhaps we could add a QOM property with the list of features? But I don't want to bikeshed too much. Paolo