From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUhD-0002eS-38 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:53:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgUh8-0003vM-2J for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:53:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56999 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUh7-0003vI-SE for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:53:45 -0400 Message-ID: <55278F97.7090304@suse.de> Date: Fri, 10 Apr 2015 10:53:43 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428519763-21644-1-git-send-email-ehabkost@redhat.com> <1428519763-21644-4-git-send-email-ehabkost@redhat.com> <20150409184830.GB18590@thinpad.lan.raisama.net> <20150410092751.3573d267@igors-macbook-pro.local> <5527881D.6040300@redhat.com> In-Reply-To: <5527881D.6040300@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Igor Mammedov , Eduardo Habkost Cc: Jiri Denemark , qemu-devel@nongnu.org Am 10.04.2015 um 10:21 schrieb Paolo Bonzini: > On 10/04/2015 09:27, Igor Mammedov wrote: >>> + for (i =3D 0; names[i]; i++) { >>> + char *feat_name =3D names[i]; >>> + feat2prop(feat_name); >>> + char *prop_name =3D g_strdup_printf("cpuid-%s", feat_name); >> >> BTW: I've remembered why we've chosen feat- vs. cpuid- prefix >> it was to make CPU features platform neutral so that libvirt >> would use the same prefix for x86, arm other targets. >=20 > Ok, that make sense, but if we want to make it platform-neutral, let's > spell it "feature-" or remove the prefix altogether. >=20 > If we remove it, perhaps we could add a QOM property with the list of > features? >=20 > But I don't want to bikeshed too much. I had suggested a container sub-object for property grouping but Anthony preferred a prefix. Btw a suffix could work as well and would read more natural. QMP don't sort alphabetically anyway. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)