From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags
Date: Fri, 10 Apr 2015 10:59:18 +0200 [thread overview]
Message-ID: <552790E6.1090305@redhat.com> (raw)
In-Reply-To: <55278F97.7090304@suse.de>
On 10/04/2015 10:53, Andreas Färber wrote:
> > Ok, that make sense, but if we want to make it platform-neutral, let's
> > spell it "feature-" or remove the prefix altogether.
> >
> > If we remove it, perhaps we could add a QOM property with the list of
> > features?
> >
> > But I don't want to bikeshed too much.
>
> I had suggested a container sub-object for property grouping but Anthony
> preferred a prefix.
And I agree. :) However, it seems to me that properties such as
feature-words and filtered-features are a good precedent so we might as
well add all-features.
> Btw a suffix could work as well and would read more natural. QMP don't
> sort alphabetically anyway.
QMP doesn't, but the front-end (scripts/qom-list for example) could.
Paolo
next prev parent reply other threads:[~2015-04-10 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 19:02 [Qemu-devel] [PATCH v2 0/4] target-i386: Feature properties, sample script for -global/-readconfig Eduardo Habkost
2015-04-08 19:02 ` [Qemu-devel] [PATCH v2 1/4] target-i386: Make "level" and "xlevel" properties static Eduardo Habkost
2015-04-09 8:14 ` Igor Mammedov
2015-04-08 19:02 ` [Qemu-devel] [PATCH v2 2/4] target-i386: X86CPU::xlevel2 QOM property Eduardo Habkost
2015-04-08 19:02 ` [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags Eduardo Habkost
2015-04-09 18:48 ` Eduardo Habkost
2015-04-10 7:27 ` Igor Mammedov
2015-04-10 8:21 ` Paolo Bonzini
2015-04-10 8:53 ` Andreas Färber
2015-04-10 8:59 ` Paolo Bonzini [this message]
2015-04-10 9:04 ` Andreas Färber
2015-04-10 15:49 ` Eduardo Habkost
2015-04-08 19:02 ` [Qemu-devel] [PATCH v2 4/4] scripts: x86-cpu-model-dump script Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552790E6.1090305@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).