From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YgUmg-00042L-3F
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:59:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YgUmb-00062w-49
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:59:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YgUma-00062m-Uy
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 04:59:25 -0400
Message-ID: <552790E6.1090305@redhat.com>
Date: Fri, 10 Apr 2015 10:59:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428519763-21644-1-git-send-email-ehabkost@redhat.com>	<1428519763-21644-4-git-send-email-ehabkost@redhat.com>	<20150409184830.GB18590@thinpad.lan.raisama.net>
	<20150410092751.3573d267@igors-macbook-pro.local>
	<5527881D.6040300@redhat.com> <55278F97.7090304@suse.de>
In-Reply-To: <55278F97.7090304@suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM
 properties for feature flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Igor Mammedov <imammedo@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>, qemu-devel@nongnu.org



On 10/04/2015 10:53, Andreas F=E4rber wrote:
> > Ok, that make sense, but if we want to make it platform-neutral, let'=
s
> > spell it "feature-" or remove the prefix altogether.
> >=20
> > If we remove it, perhaps we could add a QOM property with the list of
> > features?
> >=20
> > But I don't want to bikeshed too much.
>=20
> I had suggested a container sub-object for property grouping but Anthon=
y
> preferred a prefix.

And I agree. :)  However, it seems to me that properties such as
feature-words and filtered-features are a good precedent so we might as
well add all-features.

> Btw a suffix could work as well and would read more natural. QMP don't
> sort alphabetically anyway.

QMP doesn't, but the front-end (scripts/qom-list for example) could.

Paolo