From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUrb-0005so-6Q for qemu-devel@nongnu.org; Fri, 10 Apr 2015 05:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgUrT-0007sS-H8 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 05:04:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57532 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgUrT-0007sH-AC for qemu-devel@nongnu.org; Fri, 10 Apr 2015 05:04:27 -0400 Message-ID: <55279219.4040608@suse.de> Date: Fri, 10 Apr 2015 11:04:25 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428519763-21644-1-git-send-email-ehabkost@redhat.com> <1428519763-21644-4-git-send-email-ehabkost@redhat.com> <20150409184830.GB18590@thinpad.lan.raisama.net> <20150410092751.3573d267@igors-macbook-pro.local> <5527881D.6040300@redhat.com> <55278F97.7090304@suse.de> <552790E6.1090305@redhat.com> In-Reply-To: <552790E6.1090305@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Igor Mammedov , Eduardo Habkost Cc: Jiri Denemark , qemu-devel@nongnu.org Am 10.04.2015 um 10:59 schrieb Paolo Bonzini: > On 10/04/2015 10:53, Andreas F=E4rber wrote: >>> Ok, that make sense, but if we want to make it platform-neutral, let'= s >>> spell it "feature-" or remove the prefix altogether. >>> >>> If we remove it, perhaps we could add a QOM property with the list of >>> features? >>> >>> But I don't want to bikeshed too much. [...] >> Btw a suffix could work as well and would read more natural. QMP don't >> sort alphabetically anyway. >=20 > QMP doesn't, but the front-end (scripts/qom-list for example) could. I don't think our scripts should modify QMP responses. Some commands transmit things in reverse and we should find out why and fix them instead of papering over it. In particular for scripts/qom-tree's sibling nodes (qom-list) I find that very annoying. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)