qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: edk2-devel@lists.sourceforge.net,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu devel list <qemu-devel@nongnu.org>,
	BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [Qemu-devel] [edk2] syslinux vs. OVMF
Date: Fri, 10 Apr 2015 12:06:11 +0200	[thread overview]
Message-ID: <5527A093.30904@redhat.com> (raw)
In-Reply-To: <1428653687.11559.5.camel@nilsson.home.kraxel.org>

On 04/10/15 10:14, Gerd Hoffmann wrote:
>   Hi,
> 
>> In summary, please ask Gerd to rebuild the ipxe binaries that are
>> bundled with upstream qemu such that they include those two iPXE patches
>> of ours (see the last reference).
> 
> https://www.kraxel.org/cgit/qemu/log/?h=rebase/roms-next
> 
> Can you give this a try?

Thank you for this update, I tested it.

(1) I reproduced the issue, so that I could be sure that the fix wasn't
meaningless. Indeed the bug reproduces with the iPXE binaries bundled
with upstream qemu.

I then checked out, built and installed your branch, and tried again,
with virtio-net and then e1000.

(2) Virito-net results:
- OVMF        loads shim.efi    via network
- shim.efi    loads grubx64.efi via network
- grubx64.efi loads grub.cfg    via network
- grubx64.efi loads vmlinuz     via network

However, while grubx64.efi loads initrd.img via the network, qemu
crashes the guest, with the following message:

qemu-system-x86_64: Guest moved used index from 46499 to 65534

This is a virtio protocol bug in the guest (efi-virtio.rom), *or* in
QEMU. I don't know.

* e1000 results:
- OVMF        loads shim.efi    via network
- shim.efi    loads grubx64.efi via network
- grubx64.efi loads grub.cfg    via network
- grubx64.efi loads vmlinuz     via network
- grubx64.efi loads initrd.img  via network
- guest kernel boots

So, I think the update is fine in general; but maybe there's a new
virtio-related bug in either "efi-virtio.rom" or in QEMU.

(When I originally wrote the (earlier versions of the) patches, I tested
them with virtio-net using RHEL-7 qemu, so I guess this could be an
upstream QEMU regression. The machine type I used for testing was
pc-i440fx-2.3.)

(3) ... Confirmed, this is a qemu regression. Namely, I checked your new
efi-virtio.rom with RHEL-7 qemu, and it works fine. CC'ing qemu-devel.

(4) Independently -- can you please update the commit message on
"roms/ipxe-patches/0002-efi-make-load-file-protocol-optional.patch"?

The code is indeed all yours in that patch, but I did the initial
analysis and the first fix. Can you please add a Suggested-by, and
reference (or even: include) the analysis in
<http://lists.ipxe.org/pipermail/ipxe-devel/2015-February/003979.html>?

Thanks!
Laszlo

       reply	other threads:[~2015-04-10 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.GSO.2.01.1504062122470.1832@mono>
     [not found] ` <5523E12E.8010103@redhat.com>
     [not found]   ` <1428653687.11559.5.camel@nilsson.home.kraxel.org>
2015-04-10 10:06     ` Laszlo Ersek [this message]
2015-04-10 11:04       ` [Qemu-devel] virtio-net regression [was: syslinux vs. OVMF] Laszlo Ersek
2015-04-10 14:36         ` Laszlo Ersek
2015-04-10 19:56           ` Laszlo Ersek
2015-05-26 14:36       ` [Qemu-devel] [edk2] syslinux vs. OVMF Michael Tokarev
2015-05-26 16:49         ` Laszlo Ersek
2015-05-26 17:04           ` Michael Tokarev
2015-05-26 18:38             ` Laszlo Ersek
2015-05-26 20:17               ` BALATON Zoltan
2015-05-26 20:27                 ` Michael Tokarev
2015-05-26 20:42                   ` BALATON Zoltan
2015-05-26 21:31             ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5527A093.30904@redhat.com \
    --to=lersek@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=edk2-devel@lists.sourceforge.net \
    --cc=kraxel@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).