From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgVpN-00034K-43 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 06:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgVpJ-00049q-4H for qemu-devel@nongnu.org; Fri, 10 Apr 2015 06:06:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgVpI-00049U-UE for qemu-devel@nongnu.org; Fri, 10 Apr 2015 06:06:17 -0400 Message-ID: <5527A093.30904@redhat.com> Date: Fri, 10 Apr 2015 12:06:11 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <5523E12E.8010103@redhat.com> <1428653687.11559.5.camel@nilsson.home.kraxel.org> In-Reply-To: <1428653687.11559.5.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [edk2] syslinux vs. OVMF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: edk2-devel@lists.sourceforge.net, Michael Tokarev , qemu devel list , BALATON Zoltan On 04/10/15 10:14, Gerd Hoffmann wrote: > Hi, > >> In summary, please ask Gerd to rebuild the ipxe binaries that are >> bundled with upstream qemu such that they include those two iPXE patches >> of ours (see the last reference). > > https://www.kraxel.org/cgit/qemu/log/?h=rebase/roms-next > > Can you give this a try? Thank you for this update, I tested it. (1) I reproduced the issue, so that I could be sure that the fix wasn't meaningless. Indeed the bug reproduces with the iPXE binaries bundled with upstream qemu. I then checked out, built and installed your branch, and tried again, with virtio-net and then e1000. (2) Virito-net results: - OVMF loads shim.efi via network - shim.efi loads grubx64.efi via network - grubx64.efi loads grub.cfg via network - grubx64.efi loads vmlinuz via network However, while grubx64.efi loads initrd.img via the network, qemu crashes the guest, with the following message: qemu-system-x86_64: Guest moved used index from 46499 to 65534 This is a virtio protocol bug in the guest (efi-virtio.rom), *or* in QEMU. I don't know. * e1000 results: - OVMF loads shim.efi via network - shim.efi loads grubx64.efi via network - grubx64.efi loads grub.cfg via network - grubx64.efi loads vmlinuz via network - grubx64.efi loads initrd.img via network - guest kernel boots So, I think the update is fine in general; but maybe there's a new virtio-related bug in either "efi-virtio.rom" or in QEMU. (When I originally wrote the (earlier versions of the) patches, I tested them with virtio-net using RHEL-7 qemu, so I guess this could be an upstream QEMU regression. The machine type I used for testing was pc-i440fx-2.3.) (3) ... Confirmed, this is a qemu regression. Namely, I checked your new efi-virtio.rom with RHEL-7 qemu, and it works fine. CC'ing qemu-devel. (4) Independently -- can you please update the commit message on "roms/ipxe-patches/0002-efi-make-load-file-protocol-optional.patch"? The code is indeed all yours in that patch, but I did the initial analysis and the first fix. Can you please add a Suggested-by, and reference (or even: include) the analysis in ? Thanks! Laszlo