From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YgXs3-0000tf-0b
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:17:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YgXs0-0002ns-9w
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:17:14 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YgXrz-0002nh-Th
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:17:12 -0400
Received: by wizk4 with SMTP id k4so125685300wiz.1
	for <qemu-devel@nongnu.org>; Fri, 10 Apr 2015 05:17:11 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5527B83E.3000603@redhat.com>
Date: Fri, 10 Apr 2015 13:47:10 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428436304-24044-1-git-send-email-minyard@acm.org>
	<1428436304-24044-14-git-send-email-minyard@acm.org>
In-Reply-To: <1428436304-24044-14-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 13/15] configure: Copy some items from
 default configs to target configs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>



On 07/04/2015 21:51, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> This is to get CONFIG_ACPI into the target config so devices that may
> use ACPI know to do this or not.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
>  configure | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/configure b/configure
> index 09c9225..e301259 100755
> --- a/configure
> +++ b/configure
> @@ -5073,6 +5073,9 @@ if test "$linux" = "yes" ; then
>      fi
>  fi
>  
> +# Copy these from the default config to the target config
> +defconfig_to_target="CONFIG_ACPI"
> +
>  for target in $target_list; do
>  target_dir="$target"
>  config_target_mak=$target_dir/config-target.mak
> @@ -5431,6 +5434,10 @@ fi
>  echo "LDFLAGS+=$ldflags" >> $config_target_mak
>  echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>  
> +for i in $defconfig_to_target; do
> +        grep $i $source_path/default-configs/${target}.mak >> $config_target_mak
> +done
> +
>  done # for target in $targets
>  
>  if [ "$pixman" = "internal" ]; then
> 

This doesn't support "include" directives.

Also, it's ugly that you have to compile files per-target.

Perhaps you can use something like:

CONFIG_NOT_ACPI   := $(call lnot,$(CONFIG_ACPI))
CONFIG_NOT_SMBIOS := $(call lnot,$(CONFIG_SMBIOS))

common-obj-$(CONFIG_ISA_IPMI) += isa_ipmi.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_ACPI))     += isa_ipmi-ssdt.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_NOT_ACPI)) += isa_ipmi-ssdt-stub.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_SMBIOS))   += isa_ipmi-smbios.o
common-obj-$(call land,$(CONFIG_ISA_IPMI),$(CONFIG_NOT_ACPI)) += isa_ipmi-smbios-stub.o

# Make toplevel always build these
common-obj-$(CONFIG_ALL) += isa_ipmi-ssdt-stub.o isa_ipmi-smbios-stub.o

Paolo