From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgXm0-0006DA-CN for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgXlx-0001Bi-Kr for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:11:00 -0400 Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:32868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgXlx-0001Be-DF for qemu-devel@nongnu.org; Fri, 10 Apr 2015 08:10:57 -0400 Received: by wgin8 with SMTP id n8so15335619wgi.0 for ; Fri, 10 Apr 2015 05:10:56 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5527B891.9060601@redhat.com> Date: Fri, 10 Apr 2015 13:48:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428436304-24044-1-git-send-email-minyard@acm.org> In-Reply-To: <1428436304-24044-1-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] IPMI device for qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel On 07/04/2015 21:51, minyard@acm.org wrote: > This set of patches adds an IPMI KCS or BT interface to qemu, > along with a local simulated baseboard management controller (BMC) > and a way to connect to an external BMC. It is mostly unchanged > from previous release, except for bug fixes and the following > changes: > > The ACPI generation code custom to this was removed and it's now > using the new aml-build code. > > Because of the previous change, capability was added to hook into > the SSDT build process so that devices could insert their own > table entries. > > Also because of this, and because Benjamin Herrenschmidt pointed > out the need to have this on systems without SMBIOS and ACPI, that > code has now been made optional. The SMBIOS uses TARGET_I386 to > do this, which seems to be safe. The ACPI code required > transfering the CONFIG_ACPI entry from the default configs to the > target configs, in a new patch (patch 13). I'm not sure this was > the best way, but adding a new file to do it got messy, and this > seemed simple. Maybe there's a better way. I tried suggesting one in the reply to patch 13. It requires splitting into three files (one for basic ISA IPMI, one for SMBIOS, one for ACPI). > Also, there's lots of config options for this, and I'm not sure they > are really all necessary. Should there be just one CONFIG_IPMI that > covers everything? I think it doesn't hurt to have more flexibility. I didn't receive patch 15. Paolo