From: "Andreas Färber" <afaerber@suse.de>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name
Date: Fri, 10 Apr 2015 16:51:47 +0200 [thread overview]
Message-ID: <5527E383.7080400@suse.de> (raw)
In-Reply-To: <CAKmqyKOQ4puJR8TTQkNXOQdd4U=9_4Q_fGhu4HZ7X20x9UYggQ@mail.gmail.com>
Am 10.04.2015 um 16:47 schrieb Alistair Francis:
> On Sat, Apr 11, 2015 at 12:37 AM, Andreas Färber <afaerber@suse.de> wrote:
>> The type name for the SoC device, unlike those of its sub-devices,
>> did not follow the QOM naming conventions. While the usage is internal
>> only, this is exposed through QMP and HMP, so fix it before release.
>>
>> Cc: Alistair Francis <alistair.francis@xilinx.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> Looks good to me. Sorry about this slipping in, thanks for fixing it.
>
> Reviewed-by: Alistair Francis <alistair@alistair23.me>
Thanks. BTW a real SoC device would integrate ARMCPU as well - in that
case we would need to distinguish -arm-soc and -aarch64-soc, like we do
for CPUs.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-04-10 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:37 [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name Andreas Färber
2015-04-10 14:47 ` Alistair Francis
2015-04-10 14:51 ` Andreas Färber [this message]
2015-04-13 10:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5527E383.7080400@suse.de \
--to=afaerber@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).