From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgaQd-0000iF-4H for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgaHd-0001p9-J9 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 10:51:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48393 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgaHd-0001p1-D4 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 10:51:49 -0400 Message-ID: <5527E383.7080400@suse.de> Date: Fri, 10 Apr 2015 16:51:47 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1428676676-23056-1-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" Am 10.04.2015 um 16:47 schrieb Alistair Francis: > On Sat, Apr 11, 2015 at 12:37 AM, Andreas F=E4rber w= rote: >> The type name for the SoC device, unlike those of its sub-devices, >> did not follow the QOM naming conventions. While the usage is internal >> only, this is exposed through QMP and HMP, so fix it before release. >> >> Cc: Alistair Francis >> Signed-off-by: Andreas F=E4rber >=20 > Looks good to me. Sorry about this slipping in, thanks for fixing it. >=20 > Reviewed-by: Alistair Francis Thanks. BTW a real SoC device would integrate ARMCPU as well - in that case we would need to distinguish -arm-soc and -aarch64-soc, like we do for CPUs. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)