From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yh0Iq-00081Y-5P for qemu-devel@nongnu.org; Sat, 11 Apr 2015 14:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yh0Ik-00068G-Vu for qemu-devel@nongnu.org; Sat, 11 Apr 2015 14:38:48 -0400 Received: from resqmta-po-04v.sys.comcast.net ([2001:558:fe16:19:96:114:154:163]:55781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yh0Ik-00067e-Q5 for qemu-devel@nongnu.org; Sat, 11 Apr 2015 14:38:42 -0400 Message-ID: <552969A6.6030201@redhat.com> Date: Sat, 11 Apr 2015 12:36:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427995743-7865-1-git-send-email-armbru@redhat.com> <1427995743-7865-3-git-send-email-armbru@redhat.com> <552315E7.3050308@redhat.com> In-Reply-To: <552315E7.3050308@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uiNEMhVmilGjh9BThNsX81BG13kek7HNp" Subject: Re: [Qemu-devel] [PATCH RFC 02/19] qapi: Fix C identifiers generated for names containing '.' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uiNEMhVmilGjh9BThNsX81BG13kek7HNp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/06/2015 05:25 PM, Eric Blake wrote: > On 04/02/2015 11:28 AM, Markus Armbruster wrote: >> c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in >> QAPI names that get passed to c_var(). >> >> Which QAPI names get passed to c_fun(), to c_var(), or to both is not >> obvious. Names of command parameters and struct type members get >> passed to c_var(). >> >> c_var() strips a leading '*', but this cannot happen. c_fun() >> doesn't. >> >> Fix c_var() to work exactly like c_fun(). >> >> Perhaps they should be replaced by a single mapping function. >> >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi.py | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > In order to test if we caught everything, I tried adding: >=20 I took over this one patch, and turned it into a series: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01300.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uiNEMhVmilGjh9BThNsX81BG13kek7HNp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVKWmmAAoJEKeha0olJ0NqNIQH/0P9wMCFmqFtafSAKiUM8qwB QzO5Np3glnvzqidS374j/k+WinUOgfnJYbPFY926qLlpZrFflHKShieZCXqUQRLD LzZqaIhCO9Ys3fGQ3b/pqYR0VWvKx92sHXO5VCP4kBOX1afhARmCmFdJuUmcc6BA UMQckn70JpjWJKPzsm4DsJntUlaCnG+eX3unoJSicWCScbszd3HC5jIVODYur8F2 mweZUpZ5y+geVvUXW1BkkCW6F0urdwGLjWDkGtZI//CnOSABMNiHZgLKJlMmCYqh Rjk/RqZnW1QctNLBqTckKwpwzTFfcPlvPS5TcpGf5xCLlveLQ7miU/UjOlJpVTE= =jlww -----END PGP SIGNATURE----- --uiNEMhVmilGjh9BThNsX81BG13kek7HNp--